fix(table striped): isStriped prop fix for multiple computed values in `td` #2509

alphaxek · 2024-03-12T01:38:08Z

Fixed Table rendering the contents of the cell beneath the stripe for the multiple computed values

📝 Description

Fixed Table rendering the contents of the cell beneath the stripe (isStriped) instead of above the stripe in case of multiple computed values provided in td.

⛳️ Current behavior (updates)

Table rendering the contents of the cell beneath the stripe (isStriped) in case of multiple computed values provided in td.

🚀 New behavior

Table rendering the contents of the cell above the stripe (isStriped) for the multiple computed values in td.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

No

Summary by CodeRabbit

Bug Fixes
- Fixed an issue where table cell contents were displayed incorrectly under stripes for rows with multiple computed values.
- Improved styling for odd rows in tables to enhance visual consistency.

Fixed `Table` rendering the contents of the cell beneath the stripe for the multiple computed values

changeset-bot · 2024-03-12T01:38:11Z

🦋 Changeset detected

Latest commit: 2cf59ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/table	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-03-12T01:38:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 12, 2024 9:54pm

coderabbitai · 2024-03-12T01:38:13Z

Walkthrough

The update addresses a rendering issue in the @nextui-org/table component where cell contents were incorrectly displayed beneath the stripe in striped tables with multiple computed values. It includes a CSS class addition to ensure proper visual layering, specifically focusing on the display for odd rows as per the requirements outlined in the linked issue.

Changes

Files	Summary
`.changeset/empty-eels-compare.md` `packages/core/theme/src/components/.../table.ts`	Minor update to fix cell content rendering in striped tables with multiple computed values and introduce a CSS class for styling odd rows in striped tables.

Assessment against linked issues

Objective	Addressed	Explanation
Bug Description - Striped table display issue with multiple computed values (#2506)	✅
Reproduction Steps (#2506)	❓	The changes seem to target the issue, but without direct verification, certainty is limited.
Expected Behavior - All rows should render their contents above the background striping (#2506)	✅
Context - NextUI Version, OS, Browser (#2506)	❌	The changes do not explicitly mention compatibility fixes or version-specific adjustments.
Visuals - Correct display of striped tables (#2506)	❓	Visual verification is necessary to confirm alignment with expected display outcomes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

vercel · 2024-03-12T01:38:13Z

@alphaxek is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 5a8768a and 5de6947.

Files selected for processing (2)

.changeset/empty-eels-compare.md (1 hunks)
packages/core/theme/src/components/table.ts (1 hunks)

Additional comments: 2

.changeset/empty-eels-compare.md (1)

1-5: The changeset description is clear and accurately describes the fix implemented for the Table component. The term td is correctly used here, referring to the "table data" cell element in HTML, despite the static analysis hint suggesting a spelling mistake. This is a domain-specific term and is used appropriately in this context.

packages/core/theme/src/components/table.ts (1)

188-188: The addition of the CSS class group-data-[odd=true]:before:-z-10 is a precise fix for the rendering issue with striped tables. This change correctly adjusts the z-index for odd rows, ensuring cell contents are displayed above the stripe as expected.

Please ensure to verify the impact of this change on other table variants and configurations to confirm that it doesn't introduce any unintended side effects.

.changeset/empty-eels-compare.md

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 5de6947 and 20ef3ea.

Files selected for processing (1)

.changeset/empty-eels-compare.md (1 hunks)

Check Runs (5)

TypeScript completed (1)

Tests completed (1)

Build completed (1)

ESLint completed (1)

Prettier completed (1)

.changeset/empty-eels-compare.md

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 20ef3ea and 2cf59ca.

Files selected for processing (1)

.changeset/empty-eels-compare.md (1 hunks)

Check Runs (5)

TypeScript completed (1)

Prettier completed (1)

Build completed (1)

Tests completed (1)

ESLint completed (1)

Additional comments: 1

.changeset/empty-eels-compare.md (1)

5-5: Consider using a more formal verb such as "Resolved" or "Addressed" instead of "Fixed" to begin the change description. Additionally, the term td is correctly used in this context as it refers to a table cell element in HTML. However, enclosing technical terms or code snippets in backticks, as done here, is a good practice to distinguish them from regular text.

jrgarciadev

Thank you! @alphaxek

alphaxek added 2 commits March 12, 2024 06:50

fix(table striped): multiple computed values in td

fbcc64b

Fixed `Table` rendering the contents of the cell beneath the stripe for the multiple computed values

fix(table striped): multiple computed values in td

5de6947

alphaxek requested a review from jrgarciadev as a code owner March 12, 2024 01:38

vercel bot deployed to Preview – nextui-storybook-v2 March 12, 2024 01:40 View deployment

coderabbitai bot reviewed Mar 12, 2024

View reviewed changes

wingkwong reviewed Mar 12, 2024

View reviewed changes

.changeset/empty-eels-compare.md Outdated Show resolved Hide resolved

fix(table striped): changeset fix

20ef3ea

vercel bot deployed to Preview – nextui-storybook-v2 March 12, 2024 21:46 View deployment

coderabbitai bot reviewed Mar 12, 2024

View reviewed changes

.changeset/empty-eels-compare.md Outdated Show resolved Hide resolved

fix(table striped): changeset description enhancement

2cf59ca

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

vercel bot deployed to Preview – nextui-storybook-v2 March 12, 2024 21:54 View deployment

coderabbitai bot reviewed Mar 12, 2024

View reviewed changes

jrgarciadev approved these changes Mar 15, 2024

View reviewed changes

jrgarciadev merged commit 5ea479f into heroui-inc:main Mar 15, 2024
7 of 8 checks passed

This was referenced Mar 15, 2024

ci(changesets): 📦 version packages #2441

Merged

ci(changesets): 📦 version packages hoanghohotel/nextui#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(table striped): isStriped prop fix for multiple computed values in `td` #2509

fix(table striped): isStriped prop fix for multiple computed values in `td` #2509

alphaxek commented Mar 12, 2024 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 12, 2024 •

edited

Loading

vercel bot commented Mar 12, 2024 •

edited

Loading

coderabbitai bot commented Mar 12, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

vercel bot commented Mar 12, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

jrgarciadev left a comment

fix(table striped): isStriped prop fix for multiple computed values in td #2509

fix(table striped): isStriped prop fix for multiple computed values in td #2509

Conversation

alphaxek commented Mar 12, 2024 • edited by coderabbitai bot Loading

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

changeset-bot bot commented Mar 12, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Mar 12, 2024 • edited Loading

coderabbitai bot commented Mar 12, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

vercel bot commented Mar 12, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

jrgarciadev left a comment

Choose a reason for hiding this comment

fix(table striped): isStriped prop fix for multiple computed values in `td` #2509

fix(table striped): isStriped prop fix for multiple computed values in `td` #2509

alphaxek commented Mar 12, 2024 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 12, 2024 •

edited

Loading

vercel bot commented Mar 12, 2024 •

edited

Loading

coderabbitai bot commented Mar 12, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)